Re: [PATCH v2 3/7] drivers: reset: simple: add BCM6345 reset support

From: Ãlvaro FernÃndez Rojas
Date: Wed Jun 10 2020 - 02:06:33 EST


Hi Florian,

> El 10 jun 2020, a las 3:05, Florian Fainelli <f.fainelli@xxxxxxxxx> escribiÃ:
>
>
>
> On 6/9/2020 9:02 AM, Ãlvaro FernÃndez Rojas wrote:
>> Add support for resetting blocks through the Linux reset controller
>> subsystem for BCM63xx SoCs.
>>
>> Signed-off-by: Ãlvaro FernÃndez Rojas <noltari@xxxxxxxxx>
>
> This looks good to me, however in v1 there was a need for sleeping after
> the reset assertion, and this does not appear to be taken care of by
> default by reset-simple.c, did you determine the delay not to be necessary?

Let me do some more tests to determine if itâs really needed.

> --
> Florian