Re: [PATCH v2 0/2] fw_devlink: Improve cycle detection in DT

From: John Stultz
Date: Wed Jun 10 2020 - 00:48:02 EST


On Tue, Jun 9, 2020 at 6:19 PM Saravana Kannan <saravanak@xxxxxxxxxx> wrote:
>
> Patch 2/2 explain the series. Just using a cover letter to thread the
> series and add CC's.
>
> -Saravana
>
> v1 -> v2:
> Patch 2/2:
> - Added more comments
> - Fixed missing put_device()
> - Fixed stupid fall through in the error case
>
> Saravana Kannan (2):
> driver core: Add device_is_dependent() to linux/device.h
> of: property: Improve cycle detection when one of the devices is never
> added
>
> drivers/base/core.c | 2 +-
> drivers/of/property.c | 62 ++++++++++++++++++++++++++++++++++++++----
> include/linux/device.h | 1 +
> 3 files changed, 58 insertions(+), 7 deletions(-)

With both patches, booting with fw_devlink=on (instead of
deferred_probe_timeout=30) this allows all modules to properly load on
the db845c, and without these patches, we fail to get display.

Tested-by: John Stultz <john.stultz@xxxxxxxxxx>

thanks
-john