Re: [PATCH v2] pinctrl-single: fix pcs_parse_pinconf() return value

From: Tony Lindgren
Date: Tue Jun 09 2020 - 14:06:48 EST


* Drew Fustini <drew@xxxxxxxxxxxxxxx> [200608 12:52]:
> This patch causes pcs_parse_pinconf() to return -ENOTSUPP when no
> pinctrl_map is added. The current behavior is to return 0 when
> !PCS_HAS_PINCONF or !nconfs. Thus pcs_parse_one_pinctrl_entry()
> incorrectly assumes that a map was added and sets num_maps = 2.
...

> Fixes: 9dddb4df90d1 ("pinctrl: single: support generic pinconf")

It would be good to get an ack/tested-by from Haojian for this.

The patch looks right to me:

Acked-by: Tony Lindgren <tony@xxxxxxxxxxx>