Re: [PATCH 1/2] perf parse-events: fix an incompatible pointer

From: Arnaldo Carvalho de Melo
Date: Tue Jun 09 2020 - 11:36:45 EST


Em Mon, Jun 08, 2020 at 10:36:09PM -0700, Ian Rogers escreveu:
> Arrays are pointer types and don't need their address taking.
> Fixes: 8255718f4bed (perf pmu: Expand PMU events by prefix match)

Thanks, applied.

- Arnaldo

> Signed-off-by: Ian Rogers <irogers@xxxxxxxxxx>
> ---
> tools/perf/util/parse-events.y | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/util/parse-events.y b/tools/perf/util/parse-events.y
> index c4ca932d092d..d4e076c9c2ab 100644
> --- a/tools/perf/util/parse-events.y
> +++ b/tools/perf/util/parse-events.y
> @@ -349,7 +349,7 @@ PE_PMU_EVENT_PRE '-' PE_PMU_EVENT_SUF sep_dc
> struct list_head *list;
> char pmu_name[128];
>
> - snprintf(&pmu_name, 128, "%s-%s", $1, $3);
> + snprintf(pmu_name, sizeof(pmu_name), "%s-%s", $1, $3);
> free($1);
> free($3);
> if (parse_events_multi_pmu_add(_parse_state, pmu_name, &list) < 0)
> --
> 2.27.0.278.ge193c7cf3a9-goog
>

--

- Arnaldo