Re: [patch 113/131] mm: balance LRU lists based on relative thrashing

From: Alex Shi
Date: Tue Jun 09 2020 - 05:16:38 EST




在 2020/6/4 上午7:03, Andrew Morton 写道:
>
> + /* XXX: Move to lru_cache_add() when it supports new vs putback */

Hi Hannes,

Sorry for a bit lost, would you like to explain a bit more of your idea here?

> + spin_lock_irq(&page_pgdat(page)->lru_lock);
> + lru_note_cost(page);
> + spin_unlock_irq(&page_pgdat(page)->lru_lock);
> +


What could we see here w/o the lru_lock?

Thanks
Alex