Re: [PATCH v2] dma-pool: Fix too large DMA pools on medium systems

From: David Rientjes
Date: Mon Jun 08 2020 - 17:04:21 EST


On Mon, 8 Jun 2020, Geert Uytterhoeven wrote:

> On systems with at least 32 MiB, but less than 32 GiB of RAM, the DMA
> memory pools are much larger than intended (e.g. 2 MiB instead of 128
> KiB on a 256 MiB system).
>
> Fix this by correcting the calculation of the number of GiBs of RAM in
> the system. Invert the order of the min/max operations, to keep on
> calculating in pages until the last step, which aids readability.
>
> Fixes: 1d659236fb43c4d2 ("dma-pool: scale the default DMA coherent pool size with memory capacity")
> Signed-off-by: Geert Uytterhoeven <geert@xxxxxxxxxxxxxx>

This works as well and is much more readable. Thanks Geert!

Acked-by: David Rientjes <rientjes@xxxxxxxxxx>