Re: [PATCH v2 2/4] coccinelle: api: extend memdup_user rule with vmemdup_user()

From: Markus Elfring
Date: Mon Jun 08 2020 - 15:25:00 EST


>>> +* to = \(kvmalloc@p\|kvzalloc@p\)(size,\(GFP_KERNEL\|GFP_USER\));
>>> + if (to==NULL || ...) S1
>>> + if (copy_from_user(to, from, size) != 0)
>>> + S2
>>
>> How does the SmPL asterisk functionality fit to the operation
>> modes âorgâ and âreportâ?
>
> Make coccicheck uses --no-show-diff for org and report modes, so the * has
> no effect in those cases.

* Can it be nicer to generate only required data for each operation mode?

* Would you like to compare the usage of this command parameter with other
design approaches?

Regards,
Markus