Re: [PATCH resend] fs/namei.c: micro-optimize acl_permission_check

From: Linus Torvalds
Date: Mon Jun 08 2020 - 15:18:43 EST


On Sun, Jun 7, 2020 at 7:05 PM Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
>
> return mask & deny ? -EACCES : 0;

I agree that 'deny' would be simpler to read here, but in other places
it would look odd. ie the IS_POSIXACL() thing that checks for "are
group bits set" still wants the mode.

And I'd hate to have us use code that then mixes 'deny' and 'mode'
when they are directly related to each other.

Anyway, I merged the patch as-is, I guess we can make future changes
to this if you feel strongly about it.

Linus