liquidio vs smp_call_function_single_async()

From: Peter Zijlstra
Date: Mon Jun 08 2020 - 09:04:38 EST


Hi,

I'm going through the smp_call_function_single_async() users, and
stumbled over your liquidio thingy. It does:

call_single_data_t *csd = &droq->csd;

csd->func = napi_schedule_wrapper;
csd->info = &droq->napi;
csd->flags = 0;

smp_call_function_single_async(droq->cpu_id, csd);

which is almost certainly a bug. What guarantees that csd is unused when
you do this? What happens, if the remote CPU is already running RX and
consumes the packets before the IPI lands, and then this CPU gets
another interrupt.

AFAICT you then call this thing again, causing list corruption.