Re: [PATCH v3 2/2] phy: intel: Add Keem Bay eMMC PHY support

[Andy Shevchenko]

On Mon, Jun 08, 2020 at 04:15:01PM +0800, Wan Ahmad Zainie wrote:
> Add support for eMMC PHY on Intel Keem Bay SoC.

I think I commented on something already.

...

> +	if (ret) {
> +		dev_err(&phy->dev, "dllrdy failed, ret=%d\n", ret);

> +		return ret;
> +	}
> +
> +	return 0;

return ret;

...

> +	if (IS_ERR(priv->emmcclk)) {
> +		dev_err(&phy->dev, "ERROR: getting emmcclk\n");

> +		return PTR_ERR(priv->emmcclk);
> +	}
> +
> +	return 0;

return PTR_ERR_OR_ZERO(...);

...

> +	priv->syscfg = devm_regmap_init_mmio(dev, base,
> +					     &keembay_regmap_config);

One line.

-- 
With Best Regards,
Andy Shevchenko