Re: [PATCH] soc: amlogic: meson-gx-socinfo: Fix S905X3 ID

[Neil Armstrong]

Hi,

On 04/06/2020 06:48, Christian Hewitt wrote:
> The current value is taken from Amlogic's 4.9 bsp kernel which appears
> to use the wrong ID. For comparison, here's before/after:
> 
> [    0.152237] soc soc0: Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2) Detected
> [    0.152463] soc soc0: Amlogic Meson SM1 (S905X3) Revision 2b:c (10:2) Detected

For SM1 we have weird values, here are the one we gen on KernelCI:
SEI610 (S905D3):
Amlogic Meson SM1 (Unknown) Revision 2b:c (50:2)

VIM3L (S905D3)
Amlogic Meson SM1 (Unknown) Revision 2b:c (4:2)

And you report now:
Odroid-C4 (S905X4)
Amlogic Meson SM1 (Unknown) Revision 2b:c (10:2)

And at the time you reported:
VIM3L (S905D3)
Amlogic Meson SM1 (S905D3) Revision 2b:c (b0:2)

So I'm quite lost here....

Neil

> 
> Fixes c9cc9bec36d0 ("soc: amlogic: meson-gx-socinfo: Add SM1 and S905X3 IDs")
> Signed-off-by: Christian Hewitt <christianshewitt@xxxxxxxxx>
> ---
>  drivers/soc/amlogic/meson-gx-socinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/soc/amlogic/meson-gx-socinfo.c b/drivers/soc/amlogic/meson-gx-socinfo.c
> index 01fc0d20a70d..c38a1e4db28b 100644
> --- a/drivers/soc/amlogic/meson-gx-socinfo.c
> +++ b/drivers/soc/amlogic/meson-gx-socinfo.c
> @@ -68,7 +68,7 @@ static const struct meson_gx_package_id {
>  	{ "S905X2", 0x28, 0x40, 0xf0 },
>  	{ "S922X", 0x29, 0x40, 0xf0 },
>  	{ "A311D", 0x29, 0x10, 0xf0 },
> -	{ "S905X3", 0x2b, 0x5, 0xf },
> +	{ "S905X3", 0x2b, 0x10, 0xf0 },
>  	{ "S905D3", 0x2b, 0xb0, 0xf0 },
>  	{ "A113L", 0x2c, 0x0, 0xf8 },
>  };
>