Re: [PATCH] habanalabs: Fix static analysis error

[Oded Gabbay]

On Wed, May 27, 2020 at 11:00 AM Tomer Tayar <ttayar@xxxxxxxxx> wrote:
>
> Fix the following smatch error in unmap_device_va():
> error: uninitialized symbol 'rc'.
>
> Signed-off-by: Tomer Tayar <ttayar@xxxxxxxxx>
> ---
>  drivers/misc/habanalabs/memory.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/misc/habanalabs/memory.c b/drivers/misc/habanalabs/memory.c
> index 4b8eed1ca513..47da84a17719 100644
> --- a/drivers/misc/habanalabs/memory.c
> +++ b/drivers/misc/habanalabs/memory.c
> @@ -1023,7 +1023,7 @@ static int unmap_device_va(struct hl_ctx *ctx, u64 vaddr, bool ctx_free)
>         struct hl_va_range *va_range;
>         enum vm_type_t *vm_type;
>         bool is_userptr;
> -       int rc;
> +       int rc = 0;
>
>         /* protect from double entrance */
>         mutex_lock(&ctx->mem_hash_lock);
> --
> 2.17.1
>

This patch is:
Reviewed-by: Oded Gabbay <oded.gabbay@xxxxxxxxx>
Applied to -fixes