Re: [PATCH] net: ethernet: ti: cpsw: fix ASSERT_RTNL() warning during suspend

From: David Miller
Date: Sat May 23 2020 - 19:35:23 EST


From: Grygorii Strashko <grygorii.strashko@xxxxxx>
Date: Fri, 22 May 2020 19:39:31 +0300

> vlan_for_each() are required to be called with rtnl_lock taken, otherwise
> ASSERT_RTNL() warning will be triggered - which happens now during System
> resume from suspend:
> cpsw_suspend()
> |- cpsw_ndo_stop()
> |- __hw_addr_ref_unsync_dev()
> |- cpsw_purge_all_mc()
> |- vlan_for_each()
> |- ASSERT_RTNL();
>
> Hence, fix it by surrounding cpsw_ndo_stop() by rtnl_lock/unlock() calls.
>
> Fixes: 15180eca569b net: ethernet: ti: cpsw: fix vlan mcast
> Signed-off-by: Grygorii Strashko <grygorii.strashko@xxxxxx>

Applied.