Re: [PATCH] sh: include linux/time_types.h for sockios

From: Geert Uytterhoeven
Date: Wed May 20 2020 - 07:47:58 EST


Hi Arnd, Andrew,

On Wed, May 20, 2020 at 10:32 AM Arnd Bergmann <arnd@xxxxxxxx> wrote:
> On Wed, May 20, 2020 at 3:10 AM Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> wrote:
> > On Tue, 19 May 2020 15:13:13 +0200 Arnd Bergmann <arnd@xxxxxxxx> wrote:
> > > Using the socket ioctls on arch/sh (and only there) causes build
> > > time problems when __kernel_old_timeval/__kernel_old_timespec are
> > > not already visible to the compiler.
> > >
> > > Add an explict include line for the header that defines these
> > > structures.
> >
> > I can grab this.
>
> Thanks!
>
> > > Reported-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> > > Tested-by: John Paul Adrian Glaubitz <glaubitz@xxxxxxxxxxxxxxxxxxx>
> > > Fixes: 8c709f9a0693 ("y2038: sh: remove timeval/timespec usage from headers")
> > > Fixes: 0768e17073dc ("net: socket: implement 64-bit timestamps")
> >
> > cc:stable?
>
> Yes, I missed that.

Doesn't matter, the stable bots will pick it up anyway, based on the Fixes tag.

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds