Re: [PATCH -next] drm/amd/display: Fix unsigned comparison to zero

From: Alex Deucher
Date: Thu Apr 30 2020 - 12:32:41 EST


Applied. Thanks!

Alex

On Thu, Apr 30, 2020 at 3:33 AM Zou Wei <zou_wei@xxxxxxxxxx> wrote:
>
> Fixes coccicheck warning:
>
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c:1398:60-61:
> WARNING: Unsigned expression compared with zero: j >= 0
>
> Fixes: 238387774232 ("drm/amd/display: fix rn soc bb update")
> Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
> Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
> ---
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index ceaf70a..419cdde 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -1384,7 +1384,8 @@ static void update_bw_bounding_box(struct dc *dc, struct clk_bw_params *bw_param
> struct dcn21_resource_pool *pool = TO_DCN21_RES_POOL(dc->res_pool);
> struct clk_limit_table *clk_table = &bw_params->clk_table;
> struct _vcs_dpi_voltage_scaling_st clock_limits[DC__VOLTAGE_STATES];
> - unsigned int i, j, closest_clk_lvl;
> + unsigned int i, closest_clk_lvl;
> + int j;
>
> // Default clock levels are used for diags, which may lead to overclocking.
> if (!IS_DIAG_DC(dc->ctx->dce_environment)) {
> --
> 2.6.2
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@xxxxxxxxxxxxxxxxxxxxx
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx