[PATCH v13 0/4] perf tools: add support for libpfm4

From: Ian Rogers
Date: Thu Apr 30 2020 - 10:24:25 EST


This patch links perf with the libpfm4 library if it is available and
LIBPFM4 is passed to the build. The libpfm4 library contains hardware
event tables for all processors supported by perf_events. It is a
helper library that helps convert from a symbolic event name to the
event encoding required by the underlying kernel interface. This
library is open-source and available from: http://perfmon2.sf.net.

With this patch, it is possible to specify full hardware events
by name. Hardware filters are also supported. Events must be
specified via the --pfm-events and not -e option. Both options
are active at the same time and it is possible to mix and match:

$ perf stat --pfm-events inst_retired:any_p:c=1:i -e cycles ....

v13 moves libpfm_initialize purely into pfm.c as suggested by
acme@xxxxxxxxxxx
v12 changes NO_LIBPFM4 as a make option to LIBPFM4, ie opt-in rather
than opt-out of feature detection and build support. Suggested by
acme@xxxxxxxxxxx It also moves passing the ASCIIDOC_EXTRA argument
into its own commit.
v11 reformats the perf list output.
v10 addresses review comments from jolsa@xxxxxxxxxxx
v9 removes some unnecessary #ifs.
v8 addresses review comments from jolsa@xxxxxxxxxxx
Breaks the patch into 4, adds a test and moves the libpfm code into its
own file. perf list encoding tries to be closer to existing.
v7 rebases and adds fallback code for libpfm4 events.
The fallback code is to force user only priv level in case the
perf_event_open() syscall failed for permissions reason.
the fallback forces a user privilege level restriction on the event
string, so depending on the syntax either u or :u is needed.

But libpfm4 can use a : or . as the separator, so simply searching
for ':' vs. '/' is not good enough to determine the syntax needed.
Therefore, this patch introduces a new evsel boolean field to mark
events coming from libpfm4. The field is then used to adjust the
fallback string.
v6 was a rebase.
v5 was a rebase.
v4 was a rebase on
git://git.kernel.org/pub/scm/linux/kernel/git/acme/linux.git
branch perf/core and re-adds the tools/build/feature/test-libpfm4.c
missed in v3.
v3 is against acme/perf/core and removes a diagnostic warning.
v2 of this patch makes the --pfm-events man page documentation
conditional on libpfm4 behing configured. It tidies some of the
documentation and adds the feature test missed in the v1 patch.

Ian Rogers (1):
perf doc: pass ASCIIDOC_EXTRA as an argument

Stephane Eranian (3):
tools feature: add support for detecting libpfm4
perf pmu: add perf_pmu__find_by_type helper
perf tools: add support for libpfm4

tools/build/Makefile.feature | 3 +-
tools/build/feature/Makefile | 6 +-
tools/build/feature/test-libpfm4.c | 9 +
tools/perf/Documentation/perf-record.txt | 11 +
tools/perf/Documentation/perf-stat.txt | 10 +
tools/perf/Documentation/perf-top.txt | 11 +
tools/perf/Makefile.config | 13 ++
tools/perf/Makefile.perf | 8 +-
tools/perf/builtin-record.c | 6 +
tools/perf/builtin-stat.c | 6 +
tools/perf/builtin-top.c | 6 +
tools/perf/tests/Build | 1 +
tools/perf/tests/builtin-test.c | 9 +
tools/perf/tests/pfm.c | 203 ++++++++++++++++
tools/perf/tests/tests.h | 3 +
tools/perf/util/Build | 2 +
tools/perf/util/evsel.c | 2 +-
tools/perf/util/evsel.h | 1 +
tools/perf/util/parse-events.c | 30 ++-
tools/perf/util/parse-events.h | 4 +
tools/perf/util/pfm.c | 281 +++++++++++++++++++++++
tools/perf/util/pfm.h | 37 +++
tools/perf/util/pmu.c | 11 +
tools/perf/util/pmu.h | 1 +
24 files changed, 661 insertions(+), 13 deletions(-)
create mode 100644 tools/build/feature/test-libpfm4.c
create mode 100644 tools/perf/tests/pfm.c
create mode 100644 tools/perf/util/pfm.c
create mode 100644 tools/perf/util/pfm.h

--
2.26.2.303.gf8c07b1a785-goog