RE: [PATCH v3 1/3] hwrng: cctrng - Add dependency on OF

From: Hadar Gat
Date: Thu Apr 30 2020 - 03:40:02 EST



> -----Original Message-----
> From: linux-crypto-owner@xxxxxxxxxxxxxxx <linux-crypto-
> owner@xxxxxxxxxxxxxxx> On Behalf Of Herbert Xu
>
> On Tue, Apr 28, 2020 at 12:26:31PM +0000, Hadar Gat wrote:
> >
> > I've set COMPILE_TEST but couldn't see any problem.
> > Would you share what doesn't work?
>
> I don't have OF in my config. This driver builds just fine without OF.

Yes, it builds, but it is useless.
In include/linux/of.h there are definitions for of_property_read*() functions for the case of OF_CONFIG not being defined that simply returns -ENOSYS.

>
> Cheers,
> --
> Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx> Home Page:
> http://gondor.apana.org.au/~herbert/
> PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt