Re: [PATCH] firmware: qcom: avoid struct initialization warning on gcc-4.8

From: Stephen Boyd
Date: Wed Apr 29 2020 - 15:37:15 EST


Quoting Arnd Bergmann (2020-04-29 01:57:33)
> When building with old compilers like gcc-4.8, a struct initializer
> can warn about invalid syntax:
>
> drivers/firmware/qcom_scm-smc.c: In function 'scm_smc_call':
> drivers/firmware/qcom_scm-smc.c:94:9: error: missing braces around initializer [-Werror=missing-braces]
> struct arm_smccc_args smc = {0};
> ^
> drivers/firmware/qcom_scm-smc.c:94:9: error: (near initialization for 'smc.args') [-Werror=missing-braces]
> cc1: some warnings being treated as errors
> drivers/firmware/qcom_scm-legacy.c: In function 'scm_legacy_call':
> drivers/firmware/qcom_scm-legacy.c:139:9: error: missing braces around initializer [-Werror=missing-braces]
> struct arm_smccc_args smc = {0};
> ^
> drivers/firmware/qcom_scm-legacy.c:139:9: error: (near initialization for 'smc.args') [-Werror=missing-braces]
>
> Change this to use the empty initializer extension that
> works with all compilers.
>
> Fixes: 590e92809a58 ("firmware: qcom_scm-32: Move SMCCC register filling to qcom_scm_call")
> Fixes: 3f951ea627da ("firmware: qcom_scm-64: Move SMC register filling to qcom_scm_call_smccc")
> Signed-off-by: Arnd Bergmann <arnd@xxxxxxxx>
> ---

Reviewed-by: Stephen Boyd <swboyd@xxxxxxxxxxxx>