Re: [PATCH v3 07/17] arm64: dts: sdm845: Add DSI and MDP OPP tables and power-domains

[Rajendra Nayak]

On 4/29/2020 5:57 AM, Matthias Kaehlcke wrote:
> On Tue, Apr 28, 2020 at 07:02:55PM +0530, Rajendra Nayak wrote:
> > Add the OPP tables for DSI and MDP based on the perf state/clk
> > requirements, and add the power-domains property to specify the
> > scalable power domain.
> >
> > Signed-off-by: Rajendra Nayak <rnayak@xxxxxxxxxxxxxx>
> > ---
> >   arch/arm64/boot/dts/qcom/sdm845.dtsi | 59 ++++++++++++++++++++++++++++++++++++
> >   1 file changed, 59 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > index 36b9fb1..7a625ad 100644
> > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
> > @@ -3309,6 +3309,59 @@
> >   			#reset-cells = <1>;
> >   		};
> >   
> > +		mdp_opp_table: mdp-opp-table {
> > +			compatible = "operating-points-v2";
> > +
> > +			opp-19200000 {
> > +				opp-hz = /bits/ 64 <19200000>;
> > +				required-opps = <&rpmhpd_opp_min_svs>;
> > +			};
> > +
> > +			opp-171428571 {
> > +				opp-hz = /bits/ 64 <171428571>;
> > +				required-opps = <&rpmhpd_opp_low_svs>;
> > +			};
> > +
> > +			opp-344000000 {
> > +				opp-hz = /bits/ 64 <344000000>;
> > +				required-opps = <&rpmhpd_opp_svs_l1>;
> > +			};
> > +
> > +			opp-430000000 {
> > +				opp-hz = /bits/ 64 <430000000>;
> > +				required-opps = <&rpmhpd_opp_nom>;
> > +			};
> > +		};
>
> as commented on "[v3,03/17] arm64: dts: sdm845: Add OPP table for all qup
> devices" (https://patchwork.kernel.org/patch/11514693/) this table should
> probably be inside the 'mdp' node.

right, I will move this and the below table inside the device nodes.

> > +
> > +		dsi_opp_table: dsi-opp-table {
> > +			compatible = "operating-points-v2";
> > +
> > +			opp-19200000 {
> > +				opp-hz = /bits/ 64 <19200000>;
> > +				required-opps = <&rpmhpd_opp_min_svs>;
> > +			};
> > +
> > +			opp-180000000 {
> > +				opp-hz = /bits/ 64 <180000000>;
> > +				required-opps = <&rpmhpd_opp_low_svs>;
> > +			};
> > +
> > +			opp-275000000 {
> > +				opp-hz = /bits/ 64 <275000000>;
> > +				required-opps = <&rpmhpd_opp_svs>;
> > +			};
> > +
> > +			opp-328580000 {
> > +				opp-hz = /bits/ 64 <328580000>;
> > +				required-opps = <&rpmhpd_opp_svs_l1>;
> > +			};
> > +
> > +			opp-358000000 {
> > +				opp-hz = /bits/ 64 <358000000>;
> > +				required-opps = <&rpmhpd_opp_nom>;
> > +			};
> > +		};
> > +
>
> depending on the outcome of the discussion mentioned above this might have
> to move into the 'dsi0' node.

--
QUALCOMM INDIA, on behalf of Qualcomm Innovation Center, Inc. is a member
of Code Aurora Forum, hosted by The Linux Foundation