Re: [PATCH v3 1/5] w1_therm: fix reset_select_slave. Creating w1_therm.h

From: Greg KH
Date: Wed Apr 29 2020 - 09:44:03 EST


On Wed, Apr 29, 2020 at 03:30:48PM +0200, Akira Shimahara wrote:
> Patch for enhancement of w1_therm module.
> - Creating a w1_therm.h file to clean up the code and documenting it.
> - fix reset_select_slave function: w1_reset_select_slave() from w1_io.c
> could not be used here because a SKIP ROM command is sent if only
> one device is on the line. At the beginning of the search process,
> sl->master->slave_count is 1 even if more devices are on the line,
> causing data collision in the bus.

This should be three different patches, one to create the file by moving
the code, one to document it, and the last to do the fix.

thanks,

greg k-h