Re: [PATCH] clk/meson: Complete exception handling in meson8b_clkc_init_common()

From: Markus Elfring
Date: Wed Apr 29 2020 - 09:30:42 EST


> In common init function, when run into err branch, we didn`t
> use kfree to release kzmalloc area, this may bring in memleak

* I suggest to improve also this change description.

* Please move the resource release functions to end of
the function âmeson8b_clkc_init_commonâ here.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n450

* Will the tag âFixesâ be relevant then for the completed exception handling?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=96c9a7802af7d500a582d89a8b864584fe878c1b#n183

Regards,
Markus