Re: [PATCH] gpiolib: don't call sleeping functions with a spinlock taken

From: Andy Shevchenko
Date: Wed Apr 29 2020 - 08:38:00 EST


On Wed, Apr 29, 2020 at 9:40 AM Bartosz Golaszewski
<bgolaszewski@xxxxxxxxxxxx> wrote:
> wt., 28 kwi 2020 o 17:53 Andy Shevchenko <andy.shevchenko@xxxxxxxxx> napisaÅ(a):
> > On Tue, Apr 14, 2020 at 6:35 PM Bartosz Golaszewski
> > <bgolaszewski@xxxxxxxxxxxx> wrote:
> > > wt., 14 kwi 2020 o 14:00 Linus Walleij <linus.walleij@xxxxxxxxxx> napisaÅ(a):
> > > > On Fri, Mar 20, 2020 at 10:31 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote:

...

> > It looks like we need a mutex less function which can be used here and
> > in the call you are considering racy.
>
> The thing is this mutex is in pinctrl - we'd need to export it too so
> that gpio can use it.

Oh, I see now. So, something like

pinctrl_ext_operation_begin()
....
pinctrl_ext_operation_end()

perhaps.

--
With Best Regards,
Andy Shevchenko