Re: [PATCH 2/2] gpio: Make "offset" and "unsigned int", not just "unsigned"

From: Joe Perches
Date: Tue Apr 28 2020 - 22:32:53 EST


On Tue, 2020-04-28 at 18:04 -0700, Doug Anderson wrote:
> Hi,

<slurring but replying with hi again...>

> On Tue, Apr 28, 2020 at 5:57 PM Joe Perches <joe@xxxxxxxxxxx> wrote:
> > On Tue, 2020-04-28 at 17:50 -0700, Doug Anderson wrote:
> > > $ git grep -P -n '\bunsigned\s+(?!int|long)' include/linux/gpio/driver.h
> > include/linux/gpio/driver.h:352: unsigned offset);
> > include/linux/gpio/driver.h:354: unsigned offset);
> > include/linux/gpio/driver.h:356: unsigned offset);
> > include/linux/gpio/driver.h:358: unsigned offset);
> > include/linux/gpio/driver.h:360: unsigned offset, int value);
> > include/linux/gpio/driver.h:362: unsigned offset);
> > include/linux/gpio/driver.h:367: unsigned offset, int value);
> > include/linux/gpio/driver.h:372: unsigned offset,
> > include/linux/gpio/driver.h:375: unsigned offset);
> > include/linux/gpio/driver.h:462: unsigned offset);
> > include/linux/gpio/driver.h:660:int gpiochip_generic_request(struct gpio_chip *gc, unsigned offset);
> > include/linux/gpio/driver.h:661:void gpiochip_generic_free(struct gpio_chip *gc, unsigned offset);
> > include/linux/gpio/driver.h:662:int gpiochip_generic_config(struct gpio_chip *gc, unsigned offset,
>
> ...riiiiiggght. ...and now I run your sed script _after_ my patch
> and I get no hits. ...so I'm still confused about what you want me to
> do that's not already done in my patch.

So you did say it's the g&t.
It seems I only looked at the first diff block.

cheers, <hck>, Joe