Re: [PATCH v3 2/3] dt-bindings: add Qualcomm IPQ4019 MDIO bindings

From: Robert Marko
Date: Tue Apr 28 2020 - 12:41:09 EST


On Tue, Apr 28, 2020 at 5:09 PM Rob Herring <robh@xxxxxxxxxx> wrote:
>
> On Wed, Apr 15, 2020 at 05:02:46PM +0200, Robert Marko wrote:
> > This patch adds the binding document for the IPQ40xx MDIO driver.
> >
> > Signed-off-by: Robert Marko <robert.marko@xxxxxxxxxx>
> > Cc: Luka Perkov <luka.perkov@xxxxxxxxxx>
> > ---
> > Changes from v2 to v3:
> > * Remove status from example
> >
> > .../bindings/net/qcom,ipq40xx-mdio.yaml | 61 +++++++++++++++++++
> > 1 file changed, 61 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml
> > new file mode 100644
> > index 000000000000..8d4542ccd38c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/net/qcom,ipq40xx-mdio.yaml
> > @@ -0,0 +1,61 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual license new bindings please:
>
> (GPL-2.0-only OR BSD-2-Clause)
Ok, will change it in next revision.
>
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/net/qcom,ipq40xx-mdio.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Qualcomm IPQ40xx MDIO Controller Device Tree Bindings
> > +
> > +maintainers:
> > + - Robert Marko <robert.marko@xxxxxxxxxx>
> > +
> > +allOf:
> > + - $ref: "mdio.yaml#"
> > +
> > +properties:
> > + compatible:
> > + const: qcom,ipq40xx-mdio
>
> Don't use wildcards in compatible names. Should be SoC specific. If 'all
> the same', then use a fallback to the 1st implementation.
Ok, I will change it to qcom,ipq4019 then.
The whole IPQ40xx series uses the same controller.
>
> > +
> > + "#address-cells":
> > + const: 1
> > +
> > + "#size-cells":
> > + const: 0
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - "#address-cells"
> > + - "#size-cells"
> > +
> > +examples:
> > + - |
> > + mdio@90000 {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > + compatible = "qcom,ipq40xx-mdio";
> > + reg = <0x90000 0x64>;
> > +
> > + ethphy0: ethernet-phy@0 {
> > + reg = <0>;
> > + };
> > +
> > + ethphy1: ethernet-phy@1 {
> > + reg = <1>;
> > + };
> > +
> > + ethphy2: ethernet-phy@2 {
> > + reg = <2>;
> > + };
> > +
> > + ethphy3: ethernet-phy@3 {
> > + reg = <3>;
> > + };
> > +
> > + ethphy4: ethernet-phy@4 {
> > + reg = <4>;
> > + };
> > + };
> > --
> > 2.26.0
> >