Re: [PATCH 1/2] dt-bindings: remoteproc: qcom: pas: Add SM8250 remoteprocs

[Sibi Sankar]

Hey Bjorn,

On 2020-04-28 05:31, Bjorn Andersson wrote:
> Add the SM8250 audio, compute and sensor remoteprocs to the PAS DT
> binding.
>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@xxxxxxxxxx>
> ---
>  .../devicetree/bindings/remoteproc/qcom,adsp.txt         | 9 +++++++++
>  1 file changed, 9 insertions(+)
>
> diff --git
> a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> index 9938918b2fea..49ec30454198 100644
> --- a/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> +++ b/Documentation/devicetree/bindings/remoteproc/qcom,adsp.txt
> @@ -21,6 +21,9 @@ on the Qualcomm ADSP Hexagon core.
>  		    "qcom,sm8150-cdsp-pas"
>  		    "qcom,sm8150-mpss-pas"
>  		    "qcom,sm8150-slpi-pas"
> +		    "qcom,sm8250-adsp-pas"
> +		    "qcom,sm8250-cdsp-pas"
> +		    "qcom,sm8250-slpi-pas"
>
>  - interrupts-extended:
>  	Usage: required
> @@ -44,6 +47,9 @@ on the Qualcomm ADSP Hexagon core.
>  	qcom,sm8150-adsp-pas:
>  	qcom,sm8150-cdsp-pas:
>  	qcom,sm8150-slpi-pas:
> +	qcom,sm8250-adsp-pas:
> +	qcom,sm8250-cdsp-pas:
> +	qcom,sm8250-slpi-pas:
>  		    must be "wdog", "fatal", "ready", "handover", "stop-ack"
>  	qcom,qcs404-wcss-pas:
>  	qcom,sm8150-mpss-pas:
> @@ -105,10 +111,13 @@ on the Qualcomm ADSP Hexagon core.
>  	qcom,sdm845-cdsp-pas:
>  	qcom,sm8150-adsp-pas:
>  	qcom,sm8150-cdsp-pas:
> +	qcom,sm8250-adsp-pas:

Looks like adsp also uses lcx and lmx
similar to slpi, the rest looks good

Reviewed-by: Sibi Sankar <sibis@xxxxxxxxxxxxxx>

> +	qcom,sm8250-cdsp-pas:
>  		    must be "cx", "load_state"
>  	qcom,sm8150-mpss-pas:
>  		    must be "cx", "load_state", "mss"
>  	qcom,sm8150-slpi-pas:
> +	qcom,sm8250-slpi-pas:
>  		    must be "lcx", "lmx", "load_state"
>
>  - memory-region:

--
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project.