Re: [PATCH 2/5] coredump: Fix handling of partial writes in dump_emit()

From: Linus Torvalds
Date: Mon Apr 27 2020 - 23:36:08 EST


On Mon, Apr 27, 2020 at 8:28 PM Jann Horn <jannh@xxxxxxxxxx> wrote:
>
> After a partial write, we have to update the input buffer pointer.

Interesting. It seems this partial write case never triggers (except
for actually killing the core-dump).

Or did you find a case where it actually matters?

Your fix is obviously correct, but it also makes me go "that function
clearly never actually worked for partial writes, maybe we shouldn't
even bother?"

Linus