Re: [PATCH 0/5] coresight: Minor sparse and style fixes

From: Mathieu Poirier
Date: Mon Apr 27 2020 - 13:05:44 EST


On Sun, Apr 26, 2020 at 11:58:00AM -0700, Stephen Boyd wrote:
> I got a report that kcalloc() didn't exist in coresight-cti-platform.c
> on arm builds and that looked like we didn't include very many headers
> to get prototypes of functions like kcalloc(), etc. The first patch fixes
> this problem by including the headers and then the rest of these
> patches fix minor sparse and style issues that I saw while looking
> through the coresight directory.
>
> Pathes based on v5.7-rc1.
>
> Cc: Suzuki K Poulose <suzuki.poulose@xxxxxxx>
> Cc: Mike Leach <mike.leach@xxxxxxxxxx>
> Cc: Douglas Anderson <dianders@xxxxxxxxxxxx>
>
> Stephen Boyd (5):
> coresight: Include required headers in C files
> coresight: Mark some functions static
> coresight: Don't initialize variables unnecessarily
> coresight: Initialize arg in sparse friendly way
> coresight: Avoid casting void pointers

I have applied patches 2, 3 and 4, so no need to send them again. Note that I
dropped changes to coresight-cti.c and coresight-etb10.c in patch 2 as the
changes were already in my coresight-next branch.

Thanks,
Mathieu

>
> .../coresight/coresight-cti-platform.c | 11 ++++++++---
> .../hwtracing/coresight/coresight-cti-sysfs.c | 17 ++++++++++++-----
> drivers/hwtracing/coresight/coresight-cti.c | 6 +++---
> drivers/hwtracing/coresight/coresight-cti.h | 10 +++++++++-
> drivers/hwtracing/coresight/coresight-etb10.c | 2 +-
> drivers/hwtracing/coresight/coresight-etm3x.c | 2 +-
> drivers/hwtracing/coresight/coresight-etm4x.c | 2 +-
> .../hwtracing/coresight/coresight-platform.c | 4 ++--
> drivers/hwtracing/coresight/coresight-priv.h | 9 ++++++---
> drivers/hwtracing/coresight/coresight-tmc.c | 2 +-
> 10 files changed, 44 insertions(+), 21 deletions(-)
>
>
> base-commit: 8f3d9f354286745c751374f5f1fcafee6b3f3136
> --
> Sent by a computer, using git, on the internet
>