Re: [PATCH v13 01/11] drm/i915: Use 64-bit division macro

[Jani Nikula]

On Fri, 24 Apr 2020, Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx> wrote:
> On Fri, Apr 24, 2020 at 09:17:58AM +0300, Jani Nikula wrote:
>> On Tue, 21 Apr 2020, Guru Das Srinagesh <gurus@xxxxxxxxxxxxxx> wrote:
>> > Since the PWM framework is switching struct pwm_state.duty_cycle's
>> > datatype to u64, prepare for this transition by using DIV_ROUND_UP_ULL
>> > to handle a 64-bit dividend.
>> >
>> > To: Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx>
>> > Cc: Joonas Lahtinen <joonas.lahtinen@xxxxxxxxxxxxxxx>
>> > Cc: David Airlie <airlied@xxxxxxxx>
>> > Cc: Daniel Vetter <daniel@xxxxxxxx>
>> > Cc: Chris Wilson <chris@xxxxxxxxxxxxxxxxxx>
>> > Cc: "Ville SyrjÃlÃ" <ville.syrjala@xxxxxxxxxxxxxxx>
>> > Cc: intel-gfx@xxxxxxxxxxxxxxxxxxxxx
>> > Cc: dri-devel@xxxxxxxxxxxxxxxxxxxxx
>> >
>> 
>> Superfluous blank line.
>
> Will remove.
>
>> 
>> Anyway, please preserve the existing acks and reviews [1] so people
>> don't have to do it again.
>> 
>> BR,
>> Jani.
>> 
>> [1] http://lore.kernel.org/r/87h7yleb0i.fsf@xxxxxxxxx
>
> I dropped your Acked-by as the patch had to changed to resolve a merge
> conflict when I rebased to tip. Could you please re-review this patch?

Reviewed-by: Jani Nikula <jani.nikula@xxxxxxxxx>
Acked-by: Jani Nikula <jani.nikula@xxxxxxxxx>


-- 
Jani Nikula, Intel Open Source Graphics Center