Re: [PATCH V2 2/3] iio: adc: Add PMIC7 ADC bindings

[Jishnu Prakash]

Hi Rob,

On 4/21/2020 3:32 AM, Rob Herring wrote:
> On Wed, Apr 15, 2020 at 02:47:45PM +0530, Jishnu Prakash wrote:
> >                 of 512 will be used.
> >               - For compatible property "qcom,spmi-adc5", valid values are 250, 420
> >                 and 840. If property is not found, default value of 840 is used.
> > +            - For compatible property "qcom,spmi-adc7", valid values are 85, 340
> > +              and 1360. If property is not found, default value of 1360 is used.
> We express constraints in schema now, don't duplicate with free form
> text.
I'll remove the redundant parts of the descriptions in the next post.
> >               - For compatible property "qcom,spmi-adc-rev2", valid values are 256,
> >                 512 and 1024. If property is not present, default value is 1024.
> > +    then:
> > +      patternProperties:
> > +        "^.*@[0-9a-fx]+$":
> 'x' should not be in unit-addresses.
I'll remove it in the next post.
> > +          properties:
> > +            qcom,decimation:
> > +              items:
> Not an array, so 'items' doesn't make sense here.
I'll remove it in the next post.
> > +                enum: [ 85, 340, 1360 ]
> > +                default: 1360
> > +