Re: [PATCH 00/10] Add RZ/G1H support.

From: Lad, Prabhakar
Date: Mon Apr 27 2020 - 06:31:24 EST


Hi Geert,

On Mon, Apr 27, 2020 at 10:28 AM Geert Uytterhoeven
<geert@xxxxxxxxxxxxxx> wrote:
>
> Hi Prabhakar,
>
> On Thu, Apr 23, 2020 at 11:41 PM Lad Prabhakar
> <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx> wrote:
> > This patch series aims to add support for Renesas RZ/G1H (r8a7742) SoC.
> >
> > RZ/G1H SoC is similar to R-Car Gen2 H2 SoC.
> >
> > This patch set is based on renesas-drivers/master-v5.7-rc1.
>
> Thanks for your series!
>
> Looks mostly OK to me.
Thank you for the review. After fixing patch 8/10 shall I just post a
v2 with a single patch or the entire series ?

> The missing code part seems to be the introduction of the main
> CONFIG_ARCH_R8A7742 symbol?
>
I was planning to post them once these patches were reviewed, just
didn't wanted to flood with too many patches.

for enabling r8a7742 SoC in multi_v7_defconfig should this be only
sent out wen its accepted in shmobile_defconfig or can it be part of
same series as below ?

05ba50a4cf99 ARM: multi_v7_defconfig: Enable r8a7742 SoC
99b69d08729a ARM: shmobile: defconfig: Enable r8a7742 SoC
6b7bcd6635c7 ARM: debug-ll: Add support for r8a7742
1cf4e52e3a0e soc: renesas: Add Renesas R8A7742 config option

> I assume you plan to submit the DTS for v5.8, too, so I'll have to be
> careful and apply the binding definitions to a separate shared branch?
>
Yes I do plan to submit the DTS changes for v5.8.

Cheers,
--Prabhakar

> Thanks again!
>
> > Lad Prabhakar (10):
> > dt-bindings: power: rcar-sysc: Document r8a7742 SYSC binding
> > dt-bindings: power: rcar-sysc: Add r8a7742 power domain index macros
> > soc: renesas: rcar-sysc: add R8A7742 support
> > dt-bindings: reset: rcar-rst: Document r8a7742 reset module
> > soc: renesas: rcar-rst: Add support for RZ/G1H
> > dt-bindings: clock: renesas: cpg-mssr: Document r8a7742 binding
> > clk: renesas: Add r8a7742 CPG Core Clock Definitions
> > clk: renesas: cpg-mssr: Add R8A7742 support
> > ARM: shmobile: r8a7742: Basic SoC support
> > cpufreq: dt: Add support for r8a7742
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@xxxxxxxxxxxxxx
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds