[PATCH -next] perf script: remove unneeded conversion to bool

From: Zou Wei
Date: Sun Apr 26 2020 - 08:25:30 EST


This issue was detected by using the Coccinelle software:

tools/perf/builtin-script.c:3285:48-53: WARNING: conversion to bool not needed here
tools/perf/builtin-script.c:2839:36-41: WARNING: conversion to bool not needed here

The conversion to bool is unneeded, remove it

Reported-by: Hulk Robot <hulkci@xxxxxxxxxx>
Signed-off-by: Zou Wei <zou_wei@xxxxxxxxxx>
---
tools/perf/builtin-script.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index 02d64a9..e849747 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -2836,7 +2836,7 @@ static int parse_output_fields(const struct option *opt __maybe_unused,
break;
}
if (i == imax && strcmp(tok, "flags") == 0) {
- print_flags = change == REMOVE ? false : true;
+ print_flags = change == REMOVE;
continue;
}
if (i == imax) {
@@ -3282,7 +3282,7 @@ static char *get_script_path(const char *script_root, const char *suffix)

static bool is_top_script(const char *script_path)
{
- return ends_with(script_path, "top") == NULL ? false : true;
+ return ends_with(script_path, "top") == NULL;
}

static int has_required_arg(char *script_path)
--
2.6.2