Re: [PATCH] scripts: gtags_files_generator.sh

From: Greg KH
Date: Sun Apr 26 2020 - 03:09:34 EST


On Sun, Apr 26, 2020 at 10:44:36AM +0800, xujialu wrote:
> Add a script to generate a more precise gtags.files from *.cmd files.
>
> For navigating linux sources, it will be more efficient if gtags/cscope
> just collects source files that needed for compilation. The kernel
> makefiles already create *.cmd files that contain the files we needed,
> then just extracts files list from them and into gtags.files cause it's
> the the default name list file for gtags.
>
> make defconfig
> make
> scripts/gtags_files_generator.sh
> gtags [-f gtags.files]
>
> Enjoy with vim+gtags. :)
>
> Here is a log for comparison with 'make gtags':
>
> $ time make ARCH=arm cscope
> GEN cscope
>
> real 1m20.600s
> user 1m36.004s
> sys 0m8.192s
> $ wc -l cscope.files
> 31201 cscope.files #collected too many files we don't care
>
> $ time ./scripts/gtags_files_generator.sh
>
> Succeed, 3716 gtags.files listed!
>
> real 0m1.593s #collected files only we care
> user 0m1.704s
> sys 0m0.256s
> #collected also dts and dtsi
> $ grep dts gtags.files
> arch/arm/boot/dts/xxxxxx-clocks.dtsi
> arch/arm/boot/dts/xxxxxx.dtsi
> arch/arm/boot/dts/xxxxxxxx.dts
> arch/arm/boot/dts/xxxxxxxx.dtsi
>
> Signed-off-by: xujialu <xujialu@xxxxxxxxx>
> ---
> scripts/gtags_files_generator.sh | 48 ++++++++++++++++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100755 scripts/gtags_files_generator.sh

As this is a new version, you need to properly version your patch, as is
documented, please do that.

Also, you seem to be ignoring my previous questions/comments, which
makes me want to just ignore this patch :(

greg k-h