Re: [PATCH v2 00/11] ORC fixes

From: Ingo Molnar
Date: Sat Apr 25 2020 - 06:25:19 EST



* Josh Poimboeuf <jpoimboe@xxxxxxxxxx> wrote:

> v2:
> - Dropped three patches which technically weren't fixes. Will post them
> later as part of another patch set with more improvements.
> - Removed show_iret_regs() declaration [mbenes]
> - Added Miroslav Reviewed-by, Linus Reported-by
>
> v1 was here:
> https://lkml.kernel.org/r/cover.1584033751.git.jpoimboe@xxxxxxxxxx
>
> Jann Horn (1):
> x86/entry/64: Fix unwind hints in rewind_stack_do_exit()
>
> Josh Poimboeuf (9):
> objtool: Fix stack offset tracking for indirect CFAs
> x86/entry/64: Fix unwind hints in register clearing code
> x86/entry/64: Fix unwind hints in kernel exit path
> x86/entry/64: Fix unwind hints in __switch_to_asm()
> x86/unwind/orc: Convert global variables to static
> x86/unwind: Prevent false warnings for non-current tasks
> x86/unwind/orc: Prevent unwinding before ORC initialization
> x86/unwind/orc: Fix error path for bad ORC entry type
> x86/unwind/orc: Fix premature unwind stoppage due to IRET frames
>
> Miroslav Benes (1):
> x86/unwind/orc: Don't skip the first frame for inactive tasks

Thanks for doing this. These ORC handling bugs IMHO look serious and
widespread enough to warrant x86/urgent treatment, and the v2 series is
fixes-only.

Any objections against targeting v5.7-rc3 with this, assuming that
there's no problems found during review and it passes about a week of
testing?

Thanks,

Ingo