Re: [net-next PATCH v1 1/2] device property: Introduce fwnode_phy_find_device()

From: Greg Kroah-Hartman
Date: Fri Apr 24 2020 - 05:34:35 EST


On Fri, Apr 24, 2020 at 02:56:51PM +0530, Calvin Johnson wrote:
> On Thu, Apr 23, 2020 at 08:45:03PM -0700, Florian Fainelli wrote:
> >
> >
> > On 4/23/2020 8:16 PM, Calvin Johnson wrote:
> > > Define fwnode_phy_find_device() to iterate an mdiobus and find the
> > > phy device of the provided phy fwnode.
> > >
> > > Signed-off-by: Calvin Johnson <calvin.johnson@xxxxxxxxxxx>
> >
> > If you forget to update the MAINTAINERS file, or do not place this code
> > under drivers/net/phy/* or drivers/of/of_mdio.c then this is going to
> > completely escape the sight of the PHYLIB/PHYLINK maintainers...
>
> Did you mean the following change?
>
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -6354,6 +6354,7 @@ F:
> Documentation/devicetree/bindings/net/ethernet-phy.yaml
> F: Documentation/devicetree/bindings/net/mdio*
> F: Documentation/devicetree/bindings/net/qca,ar803x.yaml
> F: Documentation/networking/phy.rst
> +F: drivers/base/property.c
> F: drivers/net/phy/
> F: drivers/of/of_mdio.c

I really doubt the phy maintainers want to maintain all of property.c,
right? Please be kinder...

greg k-h