Re: [PATCH 4/4] net: mac80211: mlme.c: Add lockdep condition for RCU list usage

From: Johannes Berg
Date: Fri Apr 24 2020 - 05:24:52 EST


On Thu, 2020-04-09 at 13:59 +0530, madhuparnabhowmik10@xxxxxxxxx wrote:
> From: Madhuparna Bhowmik <madhuparnabhowmik10@xxxxxxxxx>
>
> ieee80211_add_vht_ie() is called with sdata->wdev.mtx held from
> ieee80211_send_assoc(). Add lockdep condition to avoid false positive
> warnings.

Again, wrong lock!

Over the course of the three patches, you've now claimed that any one of

* RTNL,
* local->iflist_mtx,
* local->mtx, and
* sdata->wdev.mtx

are sufficient to iterate the interface list, but only the first two are
really true.

johannes