Re: [PATCH 6/7] isofs: stop using ioctl_by_bdev

From: Jan Kara
Date: Fri Apr 24 2020 - 05:21:30 EST


On Fri 24-04-20 08:52:53, Christoph Hellwig wrote:
> On Thu, Apr 23, 2020 at 01:03:47PM +0200, Jan Kara wrote:
> > There's no error handling in the caller and this function actually returns
> > unsigned int... So I believe you need to return 0 here to maintain previous
> > behavior (however suspicious it may be)?
>
> Indeed, and I don't think it is suspicious at all - if we have no CDROM
> info we should assume session 0, which is the same as for non-CDROM
> devices. Fixed for the next version.

Right, I've realized that once I've checked UDF version and thought about
it for a while...

Honza
--
Jan Kara <jack@xxxxxxxx>
SUSE Labs, CR