Re: [PATCH v2] kvm_host: unify VM_STAT and VCPU_STAT definitions in a single place

From: Cornelia Huck
Date: Wed Apr 15 2020 - 12:21:53 EST


On Tue, 14 Apr 2020 17:56:25 +0200
Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx> wrote:

> The macros VM_STAT and VCPU_STAT are redundantly implemented in multiple
> files, each used by a different architecure to initialize the debugfs
> entries for statistics. Since they all have the same purpose, they can be
> unified in a single common definition in include/linux/kvm_host.h
>
> Signed-off-by: Emanuele Giuseppe Esposito <eesposit@xxxxxxxxxx>
> ---
> arch/arm64/kvm/guest.c | 23 ++---
> arch/mips/kvm/mips.c | 61 ++++++------
> arch/powerpc/kvm/book3s.c | 61 ++++++------
> arch/powerpc/kvm/booke.c | 41 ++++----
> arch/s390/kvm/kvm-s390.c | 203 +++++++++++++++++++-------------------
> arch/x86/kvm/x86.c | 80 +++++++--------
> include/linux/kvm_host.h | 5 +
> 7 files changed, 231 insertions(+), 243 deletions(-)

Adds a bit of churn, but the end result does look nicer. Looks sane,
but did not review in detail.

Acked-by: Cornelia Huck <cohuck@xxxxxxxxxx>