Re: [PATCH] i2c: stm32: don't print an error on probe deferral

From: Wolfram Sang
Date: Wed Apr 15 2020 - 07:05:51 EST


> if (IS_ERR(dma->chan_tx)) {
> - dev_dbg(dev, "can't request DMA tx channel\n");
> ret = PTR_ERR(dma->chan_tx);
> + if (ret != -EPROBE_DEFER)
> + dev_dbg(dev, "can't request DMA tx channel\n");

dev_dbg for tx...

> goto fail_al;
> }
>
> @@ -44,8 +45,10 @@ struct stm32_i2c_dma *stm32_i2c_dma_request(struct device *dev,
> /* Request and configure I2C RX dma channel */
> dma->chan_rx = dma_request_chan(dev, "rx");
> if (IS_ERR(dma->chan_rx)) {
> - dev_err(dev, "can't request DMA rx channel\n");
> ret = PTR_ERR(dma->chan_rx);
> + if (ret != -EPROBE_DEFER)
> + dev_err(dev, "can't request DMA rx channel\n");

... and dev_err for rx? Intentional?

Attachment: signature.asc
Description: PGP signature