Re: [PATCH] tpm: fix wrong return value in tpm_pcr_extend

From: Jarkko Sakkinen
Date: Tue Apr 14 2020 - 15:35:51 EST


On Tue, Apr 14, 2020 at 11:55:43AM +0000, Roberto Sassu wrote:
> > -----Original Message-----
> > From: linux-integrity-owner@xxxxxxxxxxxxxxx [mailto:linux-integrity-
> > owner@xxxxxxxxxxxxxxx] On Behalf Of Tianjia Zhang
> > Sent: Tuesday, April 14, 2020 1:42 PM
> > To: peterhuewe@xxxxxx; jarkko.sakkinen@xxxxxxxxxxxxxxx; jgg@xxxxxxxx;
> > arnd@xxxxxxxx; gregkh@xxxxxxxxxxxxxxxxxxx; zhang.jia@xxxxxxxxxxxxxxxxx
> > Cc: linux-integrity@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> > tianjia.zhang@xxxxxxxxxxxxxxxxx
> > Subject: [PATCH] tpm: fix wrong return value in tpm_pcr_extend
> >
> > For the algorithm that does not match the bank, a positive
> > value EINVAL is returned here. I think this is a typo error.
> > It is necessary to return an error value.
>
> Yes, thanks.
>
> Reviewed-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx>

Happen to have the commit ID at hand for fixes?

Thanks.

/Jarkko