Re: [v2] mm/ksm: Fix NULL pointer dereference when KSM zero page is enabled

From: Markus Elfring
Date: Tue Apr 14 2020 - 10:18:04 EST


>>> to crash when we access vma->vm_mm(its offset is 0x40) later in
>>
>> Will another fine-tuning become relevant also for this wording?
>
> Sorry, I don't understand what this means because of my poor English.

Our language knowledge can evolve over time.


> Could you explain it again.

You integrated a few of my suggestions into your message selection. - Thanks.
I wonder why you did not like the following small adjustment possibilities
so far.

to a crash â vm_mm (its â


>> Will any other tags become helpful in such a case?
>
> How about changing
> "following calltrace is captured in kernel 4.19 with KSM zero page"
> to
> "The following calltrace is captured with the following patch applied:
> e86c59b1b12d ("mm/ksm: improve deduplication of zero pages with
> colouring")
> "
> ?

I find it unlikely that such a wording alternative would be more appropriate
while I became just curious for related development consequences around
the usage of a longterm kernel version.

Would you like to reuse the term âcall traceâ?

Regards,
Markus