Re: [PATCH] media: Kconfig: Don't expose API options

From: Mauro Carvalho Chehab
Date: Tue Apr 14 2020 - 09:28:57 EST


Em Tue, 14 Apr 2020 15:21:47 +0200
Mauro Carvalho Chehab <mchehab@xxxxxxxxxx> escreveu:

> Em Tue, 14 Apr 2020 10:02:10 -0300
> Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx> escreveu:
>
> > There is no need to expose API options; instead,
> > drivers that support a given API are expected to just select it.
> >
> > Happily, this is currently the case, so simply stop
> > exposing the options.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel@xxxxxxxxxxxxx>
> > ---
> > drivers/media/Kconfig | 2 +-
> > drivers/media/mc/Kconfig | 3 +--
> > drivers/media/v4l2-core/Kconfig | 2 +-
> > 3 files changed, 3 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/media/Kconfig b/drivers/media/Kconfig
> > index a8def1591352..eef4c6761ffb 100644
> > --- a/drivers/media/Kconfig
> > +++ b/drivers/media/Kconfig
> > @@ -173,7 +173,7 @@ config VIDEO_DEV
> > radio devices and by some input devices.
> >
> > config MEDIA_CONTROLLER
> > - bool "Media Controller API"
> > + bool
>
> This is not true here... non-embedded drivers like DVB and UVC can work
> with or without the media controller. For them, the API is experimental.

Heh.... I meant to say:

For them, the API is ***optional***.

Thanks,
Mauro