Re: [PATCH v5 0/2] selftests: kvm: Introduce the mem_slot_test test

From: Andrew Jones
Date: Tue Apr 14 2020 - 02:17:23 EST


On Fri, Apr 10, 2020 at 01:45:09PM -0700, Sean Christopherson wrote:
> On Thu, Apr 09, 2020 at 07:09:03PM -0300, Wainer dos Santos Moschetta wrote:
> > This series introduces a new KVM selftest (mem_slot_test) that goal
> > is to verify memory slots can be added up to the maximum allowed. An
> > extra slot is attempted which should occur on error.
> >
> > The patch 01 is needed so that the VM fd can be accessed from the
> > test code (for the ioctl call attempting to add an extra slot).
> >
> > I ran the test successfully on x86_64, aarch64, and s390x. This
> > is why it is enabled to build on those arches.
>
> Any objection to folding these patches into a series I have to clean up
> set_memory_region_test (which was mentioned in a prior version) and add
> this as a testcase to set_memory_region_test instead of creating a whole
> new test?
>
> A large chunk of set_memory_region_test will still be x86_64 only, but
> having the test reside in common code will hopefully make it easier to
> extend to other architectures.
>

Yes, that would be my preference as well. Eventually I decided it could be
done later, but I still prefer it being done from the beginning.

Thanks,
drew