Re: [PATCH] cifs: improve read performance for page size 64KB & cache=strict & vers=2.1+

From: Steve French
Date: Mon Apr 13 2020 - 21:13:57 EST


merged into cifs-2.6.git for-next pending testing

On Mon, Apr 13, 2020 at 11:39 AM Pavel Shilovsky via samba-technical
<samba-technical@xxxxxxxxxxxxxxx> wrote:
>
> Looks good, thanks!
>
> Reviewed-by: Pavel Shilovsky <pshilov@xxxxxxxxxxxxx>
>
> --
> Best regards,
> Pavel Shilovsky
>
> ÐÑ, 12 ÐÐÑ. 2020 Ð. Ð 19:23, Jones Syue <jonessyue@xxxxxxxx>:
> >
> > Hello Pavel
> >
> > Thanks for kindly reviewing!
> > Please find the attached v2.patch.
> >
> > --
> > Regards,
> > Jones Syue | èæå
> > QNAP Systems, Inc.
> >
> >
> > On Sat, Apr 11, 2020 at 2:25 AM Pavel Shilovsky <piastryyy@xxxxxxxxx> wrote:
> > >
> > > Hi Jones,
> > >
> > > Thanks for the patch!
> > >
> > > It will work although it is probably a little bit cleaner to
> > > initialize server->max_read to server->maxBuf for SMB1 and use the
> > > server->max_read in the readpages condition check instead.
> > >
> > > @Others, thoughts?
> > >
> > > --
> > > Best regards,
> > > Pavel Shilovsky
>


--
Thanks,

Steve