Re: [PATCH] sh: fix build error in mm/init.c

From: Masahiro Yamada
Date: Mon Apr 13 2020 - 12:05:34 EST


On Tue, Apr 14, 2020 at 12:43 AM Logan Gunthorpe <logang@xxxxxxxxxxxx> wrote:
>
>
>
> On 2020-04-12 7:47 p.m., Masahiro Yamada wrote:
> > The closing parenthesis is missing.
> >
> > Fixes: bfeb022f8fe4 ("mm/memory_hotplug: add pgprot_t to mhp_params")
> > Signed-off-by: Masahiro Yamada <masahiroy@xxxxxxxxxx>
> > ---
>
> Oh, oops, I thought I compile checked all the arches. Must have been a
> last minute change. I'm also surprised the kbuild robot didn't catch this.
>
> Reviewed-by: Logan Gunthorpe <logang@xxxxxxxxxxxx>
>
> Andrew, can this be squashed into the existing patch?


The offending commit is already in Linus' tree.

I was also surprised that no bot or human
complained about this breakage before it was merged.



--
Best Regards
Masahiro Yamada