Re: [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource

From: Jonathan Cameron
Date: Mon Apr 13 2020 - 11:37:47 EST


On Sun, 12 Apr 2020 19:20:20 +0530
Aishwarya R <aishwaryarj100@xxxxxxxxx> wrote:

> From: Aishwarya Ramakrishnan <aishwaryarj100@xxxxxxxxx>
>
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.It reduces boilerplate and suggested by coccinelle.
>
> Signed-off-by: Aishwarya Ramakrishnan <aishwaryarj100@xxxxxxxxx>
Again see earlier patches for comments but applied anyway to
save myself time.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index fa71489195c6..b0a4dc88ba9b 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> struct mx25_gcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
> struct device *dev = &pdev->dev;
> - struct resource *res;
> void __iomem *mem;
> int ret;
> int i;
> @@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
>
> priv = iio_priv(indio_dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>