Re: [PATCH] checkpatch: check for missing \n at the end of logging message

From: Joe Perches
Date: Sat Apr 11 2020 - 06:19:14 EST


On Sat, 2020-04-11 at 09:12 +0200, Christophe JAILLET wrote:
> ./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
>
> is missing line 189, even if it looks like a construction correctly spotted in some other files:
> if (foo) {
> dev_err(...);
> ...
> };

Hi Christophe, many thanks for doing more testing

Are you sure about this one? I get:

$ ./scripts/checkpatch.pl -f drivers/soc/kendryte/k210-sysctl.c
WARNING: Possible missing '\n' at the end of a logging message format string
#189: FILE: drivers/soc/kendryte/k210-sysctl.c:189:
+ dev_err(&pdev->dev, "failed to register clk");