ASoC: s3c-i2s-v2 regression, was: [GIT PULL] sound updates for 5.6-rc1

From: Arnd Bergmann
Date: Sat Apr 11 2020 - 04:48:27 EST


On Tue, Jan 28, 2020 at 9:21 AM Takashi Iwai <tiwai@xxxxxxx> wrote:

> Kuninori Morimoto (66):
> ASoC: bcm: cygnus-ssp: move .suspend/.resume to component
> ASoC: atmel: atmel_ssc_dai: move .suspend/.resume to component
> ASoC: cirrus: ep93xx-i2s: move .suspend/.resume to component
> ASoC: jz4740: jz4740-i2s: move .suspend/.resume to component
> ASoC: mediatek: move .suspend/.resume to component
> ASoC: samsung: s3c24xx-i2s: move .suspend/.resume to component
> ASoC: samsung: spdif: move .suspend/.resume to component
> ASoC: sti: sti_uniperif: move .suspend/.resume to component
> ASoC: ti: omap-mcpdm: move .suspend/.resume to component
> ASoC: uniphier: move .suspend/.resume to component
> ASoC: dwc: dwc-i2s: move .suspend/.resume to component
> ASoC: samsung: i2s: move .suspend/.resume to component
> ASoC: ux500: ux500_msp_dai: remove unused DAI .suspend/.resume
> ASoC: pxa: pxa-ssp: move .suspend/.resume to component
> ASoC: pxa: pxa2xx-i2s: move .suspend/.resume to component
> ASoC: soc-core: remove DAI suspend/resume

I only found it now during randconfig testing, but it seems that there is
(at least) one patching in this conversion series that was part of linux-5.6:

sound/soc/samsung/s3c-i2s-v2.c: In function 's3c_i2sv2_register_component':
sound/soc/samsung/s3c-i2s-v2.c:726:9: error: 'struct
snd_soc_dai_driver' has no member named 'suspend'
726 | dai_drv->suspend = s3c2412_i2s_suspend;
| ^~
sound/soc/samsung/s3c-i2s-v2.c:727:9: error: 'struct
snd_soc_dai_driver' has no member named 'resume'
727 | dai_drv->resume = s3c2412_i2s_resume;
| ^~

I tried fixing it myself but could not see an obvious solution. Can someone
else who understands this code better than me have a look?

Arnd