Re: [PATCH v11 0/2] drm: bridge: Add NWL MIPI DSI host controller support

From: Guido Günther
Date: Fri Apr 10 2020 - 06:48:41 EST


Hi,
On Thu, Apr 09, 2020 at 04:01:30PM +0200, Sam Ravnborg wrote:
> Hi Guido.
>
> On Thu, Apr 09, 2020 at 12:42:00PM +0200, Guido Günther wrote:
> > This adds initial support for the NWL MIPI DSI Host controller found on i.MX8
> > SoCs.
> >
> > It adds support for the i.MX8MQ but the same IP core can also be found on e.g.
> > i.MX8QXP. I added the necessary hooks to support other imx8 variants but since
> > I only have imx8mq boards to test I omitted the platform data for other SoCs.
> >
> > The code is based on NXPs BSP so I added Robert Chiras as Co-authored-by.
> >
> > The most notable changes over the BSP driver are
> > - Calculate HS mode timing from phy_configure_opts_mipi_dphy
> > - Perform all clock setup via DT
> > - Merge nwl-imx and nwl drivers
> > - Add B0 silion revision quirk
> > - become a bridge driver to hook into mxsfb / dcss
> > imx-display-subsystem so it makes sense to make it drive a bridge for dsi as
> > well).
> > - Use panel_bridge to attach the panel
> > - Use multiplex framework instead of accessing syscon directly
> >
> > This has been tested on a Librem 5 devkit using mxsfb with Robert's patches[1]
> > and the mainline rocktech-jh057n00900 DSI panel driver on next-20200317 and on
> > the Librem5 with the a Mantix MLAF057WE51-X DSI panel driver (not yet mainline)
> > The DCSS (submitted for mainline inclusion now too) can also act as input
> > source.
>
> Thanks for your persistence with this driver.
> I got ack from Laurent on IRC to apply it (not for the driver as he had
> no time to review it).
> So applied to drm-misc-next now.
>
> I look forward for the update to support DRM_BRIDGE_ATTACH_NO_CONNECTOR
> in this driver and the corresponding display driver.

Thanks. I'll have a look at that (currently checking where the larger
mxsfb rework of Laurent is going so i can use that as a base
eventually).
Cheers,
-- Guido