Re: [RFC PATCH 00/26] Runtime paravirt patching

From: Ankur Arora
Date: Fri Apr 10 2020 - 05:33:04 EST


On 2020-04-08 5:28 a.m., JÃrgen Groà wrote:
On 08.04.20 07:02, Ankur Arora wrote:
[ snip ]

Quite a lot of code churn and hacks for a problem which should not
occur on a well administrated machine.
Yeah, I agree the patch set is pretty large and clearly the NMI or
the stop_machine() are completely out. That said, as I wrote in my
other mail I think the problem is still worth solving.

Especially the NMI dependencies make me not wanting to Ack this series.
The NMI solution did turn out to be pretty ugly.

I was using it to solve two problems: avoid a deadlock where an NMI handler
could use a lock while the stop_machine() thread is trying to rewrite the
corresponding call-sites. And, needed to ensure that we don't lock
and unlock using mismatched primitives.


Thanks
Ankur



Juergen