RE: [PATCH v7 7/8] PCI: Add Renesas R8A774C0 device ID

From: Yoshihiro Shimoda
Date: Thu Apr 09 2020 - 20:12:56 EST


Hi Prabhakar, Sergei, Bjorn,

> From: Lad, Prabhakar, Sent: Thursday, April 9, 2020 7:05 PM
<snip>
> > > diff --git a/include/linux/pci_ids.h b/include/linux/pci_ids.h
> > > index 1dfc4e1dcb94..9e957c18abeb 100644
> > > --- a/include/linux/pci_ids.h
> > > +++ b/include/linux/pci_ids.h
> > > @@ -2460,6 +2460,7 @@
> > > #define PCI_DEVICE_ID_RENESAS_SH7763 0x0004
> > > #define PCI_DEVICE_ID_RENESAS_SH7785 0x0007
> > > #define PCI_DEVICE_ID_RENESAS_SH7786 0x0010
> > > +#define PCI_DEVICE_ID_RENESAS_R8A774C0 0x002d
> >
> > We don't add the device IDs in this file, unless used in several places.
> > Is it?
> >
> My bad I should have checked it before making this change actually it
> was suggested in my previous version of the series but anyway atm this
> was planned to be used only in pci_endpoint_test driver, so in that
> case Ill drop this patch.

I'm very sorry, this is my fault. I suggested this but I didn't check
this pci_ids.h's rule...

Best regards,
Yoshihiro Shimoda